Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playlist empty state bug #23117

Merged
merged 3 commits into from
Jun 20, 2024
Merged

fix: playlist empty state bug #23117

merged 3 commits into from
Jun 20, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jun 20, 2024

Problem

Noticed a bug with the new playlist UI that was rendered the count 0 in cases when the list was empty

Changes

Before After
Screenshot 2024-06-20 at 14 19 18 Screenshot 2024-06-20 at 14 23 39

@daibhin daibhin requested a review from a team June 20, 2024 13:26
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Size Change: +142 B (+0.01%)

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.06 MB +142 B (+0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit 1073e2e into master Jun 20, 2024
91 checks passed
@daibhin daibhin deleted the dn-fix/playlist-empty-count branch June 20, 2024 14:27
thmsobrmlr pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants