Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys branching): handle question deletion/rearrangement #23109

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Jun 20, 2024

Changes

If a survey has branching defined and the user tries to delete or rearrange questions:

  • show a warning dialog
  • delete all branching if dialog confirmed

We could theoretically try to detect if the given action actually affects branching, but not worth the effort at this point imo.

image

Follow-ups:

  • Branching logic currently assumes the confirmation message is always present - make sure this is handled correctly
  • Disable questions shuffling when branching logic is active and vice versa

How did you test this code?

👀

@jurajmajerik jurajmajerik requested a review from a team June 20, 2024 11:14
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, follow ups make sense 👍

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@jurajmajerik jurajmajerik enabled auto-merge (squash) June 20, 2024 11:32
@jurajmajerik jurajmajerik merged commit 3ce1a89 into master Jun 20, 2024
91 checks passed
@jurajmajerik jurajmajerik deleted the branching-question-deletion-rearrangement branch June 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants