feat(cdp): Native slack integration #23103
Conversation
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
…to feat/cdp-native-slack
# Conflicts: # frontend/__snapshots__/exporter-exporter--funnel-historical-trends-insight--dark.png # frontend/__snapshots__/exporter-exporter--funnel-historical-trends-insight--light.png
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…to feat/cdp-native-slack
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| src="https://platform.slack-edge.com/img/add_to_slack.png" | ||
| srcSet="https://platform.slack-edge.com/img/add_to_slack.png 1x, https://platform.slack-edge.com/img/[email protected] 2x" |
There was a problem hiding this comment.
Due to self-hosting, airgaps, URLs changing, etc, we should just self-host these images.
There was a problem hiding this comment.
So last time I tried to get the slack app approved they would only do so if they could see were using their actual image 🤷
Problem
I've wanted to do this ever since I first added the Slack subscriptions integration.
Slack have basically made standard webhooks a miserable experience to work with. We already have an abstract Integration table containing the slack configs so I figured we could actually take advantage of that nicely, exposing the configs to functions that ask for it.
I think this is gonna come in really handy from a UX perspective. Ideally we solve most things in the templating but having an escape hatch for things like this will allow us to build much richer dynamic config / auth options over time.
Changes
Config
Output
TODO
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?