Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Fix trends actors query not using series properties with actions #23094

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

Fixes #22978

Changes

Move entity.properties conditions check

Does this work well for both Cloud and self-hosted?

n/a

How did you test this code?

Use debug query

{
  "kind": "DataTableNode",
  "source": {
    "kind": "ActorsQuery",
    "source": {
      "kind": "InsightActorsQuery",
      "source": {
        "kind": "TrendsQuery",
        "filterTestAccounts": false,
        "series": [
          {
            "kind": "ActionsNode",
            "id": "1",
            "name": "Interacted with file",
            "properties": [
              {
                "key": "$feature/signup-page-4.0",
                "value": "is_not_set",
                "operator": "is_not_set",
                "type": "event"
              }
            ],
            "math": "dau"
          }
        ],
        "interval": "day",
        "trendsFilter": {
          "display": "BoldNumber"
        },
        "dateRange": {
          "date_from": "-1233d",
          "date_to": ""
        },
        "properties": {
          "type": "AND",
          "values": [
            {
              "type": "AND",
              "values": [
                {
                  "key": "id",
                  "value": 2,
                  "type": "cohort"
                }
              ]
            }
          ]
        }
      },
      "includeRecordings": true
    },
    "orderBy": [
      "event_count DESC, actor_id DESC"
    ],
    "search": ""
  },
  "full": true
}

@webjunkie webjunkie requested a review from a team June 20, 2024 08:25
@webjunkie webjunkie merged commit a2ebfed into master Jun 21, 2024
85 checks passed
@webjunkie webjunkie deleted the fix/trends-actors-query-series-properties branch June 21, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actors query do not take actions filter into account
2 participants