fix(insights): support editing insights by updating source #23092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#17839
Changes
Propagate insight changes if changes come from the source editor.
The solution is not very pretty, but it's the best I could come up with. So in Insight we create the setQuery callback that updates the query if it's not an InsightQueryViz. This
if
is needed because if it is an InsightQueryViz, setQuery is already called from another place, and calling here setQuery will cause an infinite recursion. Recursion happens because we setsetQuery
here and then here is where the recursion happens, props.setQuery is exactly the action.setQuery. I understand the explanation could not be less clear, but I hope nobody will read it.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
A Cypress test + manually (see the screencast).