fix: Do not retry on TemporalScheduleNotFoundError #23088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already not retrying in the main backfill activity. However, we were not catching this error in the first `get_schedule_frequency` activity, which can fail indefinitely.
Gilbert09
approved these changes
Jun 19, 2024
tomasfarias
deleted the
fix/error-if-schedule-not-found-while-getting-frequency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We shouldn't backfill a schedule that no longer exists. We'll raise an
TemporalScheduleNotFoundErrorexception is that the case. However, we were not catching this error in the firstget_schedule_frequencyactivity, which can cause it to fail and retry indefinitely.Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?