Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added skip to flakey snapshot #23087

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

benjackwhite
Copy link
Contributor

Problem

Couple of snapshots that have been super flakey and driving me mad

Changes

  • Skip them

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@benjackwhite benjackwhite marked this pull request as ready for review June 19, 2024 13:32
@benjackwhite benjackwhite requested a review from Twixes June 19, 2024 13:32
# Conflicts:
#	frontend/__snapshots__/exporter-exporter--funnel-historical-trends-insight--dark.png
#	frontend/__snapshots__/exporter-exporter--funnel-historical-trends-insight--light.png
@benjackwhite benjackwhite merged commit 4b5aff4 into master Jun 20, 2024
15 of 19 checks passed
@benjackwhite benjackwhite deleted the fix/skip-flakey-snapshots branch June 20, 2024 10:41
thmsobrmlr pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants