feat(hog): refactor code editors, hog validation #23054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
EDsCODE
reviewed
Jun 28, 2024
| ], | ||
| })), | ||
| selectors({ | ||
| isValidView: [(s) => [s.metadata], (metadata) => !!(metadata && metadata[1]?.isValidView)], |
There was a problem hiding this comment.
metadata isn't updating now -> hogQLQueryEditorLogic connection to this field isn't updating either so this value is always false. Trying to debug right now but noting for visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HogQLQueryEditorand moves it intoCodeEditor. The reason is thatHogQLQueryEditorexploded in scope, now containing data warehouse and AI features we don't need.codeEditorLogicthat takes care of errors and validation based on the languageprogramto theHogQLMetadataquery and uses it to validate Hog programsNotImplementedErrors (not exposed) intoQueryError/SyntaxError(exposed to users)Not yet here (coming soon):
How did you test this code?
Show don't tell
With the python parser (syntax errors are parsed correctly, is slow)
With the CPP parser (syntax errors are not parsed, is fast)
