-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Use max_bytes_before_external_group_by for funnels and path que… #23022
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: posthog/hogql_queries/insights/funnels/funnels_query_runner.py
📄 File: posthog/hogql_queries/insights/paths_query_runner.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks out ✅
🚢 it
#23022) * perf: Use max_bytes_before_external_group_by for funnels and path queries * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * fix test * also do retention query * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
It seems like there is no way to enforce the "spill to disk" behavior anymore, because it just defaults to |
…ries
Problem
Some queries fail with OOM errors. They don't actually have to fail, it could just swap to disk instead.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?