Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-warehouse): Enable incrementality for all stripe tables #23020

Merged
merged 4 commits into from
Jun 18, 2024
Merged

feat(data-warehouse): Enable incrementality for all stripe tables #23020

merged 4 commits into from
Jun 18, 2024

Conversation

Gilbert09
Copy link
Member

Changes

  • Enabled incrementality for all stripe tables
  • Updated pipeline name to use schema id instead of run id every time
  • Fixed the balance transaction table name
  • Updated the S3 URL to use the schema id instead of the run id

Does this work well for both Cloud and self-hosted?

Yup

How did you test this code?

Tested a bunch locally

@Gilbert09 Gilbert09 requested a review from EDsCODE June 17, 2024 14:42
@Gilbert09 Gilbert09 merged commit 3f233ec into master Jun 18, 2024
83 checks passed
@Gilbert09 Gilbert09 deleted the tom/stripe-incremental branch June 18, 2024 09:13
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jun 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ExternalDataSource.DoesNotExist: ExternalDataSource matching query does not exist. /api/projects/{parent_lookup_team_id}/external_... View Issue

Did you find this useful? React with a 👍 or 👎

@EDsCODE EDsCODE mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @EDsCODE