Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show filters on group page #23018

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jun 17, 2024

Problem

We do not persist filters from the index page to the group

Changes

  • Given the filters are all property filters let's carry them over. Now you will only see a subset of exceptions ( / events) returned on the group page
  • Rewrite the group logic as an EventsQuery to remove the raw hogql from the frontend

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Not yet

@daibhin daibhin requested a review from a team June 17, 2024 13:26
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@daibhin daibhin merged commit 1690aaf into master Jun 17, 2024
91 checks passed
@daibhin daibhin deleted the dn-feat/error-group-filters branch June 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants