Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fix breakdown query memory usage #23016

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jun 17, 2024

Problem

My breakdown refactor caused a couple of queries to OOM.

Changes

Use arrayFold instead of arrayMap, which makes these queries take way less memory

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@timgl timgl requested review from tkaemming and aspicer June 17, 2024 12:49
Copy link
Contributor

@aspicer aspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timgl timgl merged commit 3f6c1f5 into master Jun 18, 2024
83 checks passed
@timgl timgl deleted the fix-breakdown-memory-usage branch June 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants