Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Removed pipeline dir #23011

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

Gilbert09
Copy link
Member

Problem

  • The DLT pipeline has a custom dir set, which is only to store temp files.
  • From what I can tell, we don't need this in the temporal workers, and it makes things harder to debug locally when using the DLT CLI. e.g. when trying to debug a local pipeline, it can't be found as the job is (a) within subfolders, and (b) in a custom directory

image

Changes

  • Removes the custom dir for the pipeline temp files
  • Has no impact on how the files in S3 are written or read

image

Does this work well for both Cloud and self-hosted?

Yep

How did you test this code?

Locally

@Gilbert09 Gilbert09 requested a review from EDsCODE June 17, 2024 10:22
@Gilbert09 Gilbert09 merged commit b094d50 into master Jun 17, 2024
83 checks passed
@Gilbert09 Gilbert09 deleted the tom/dlt=pipeline-dir branch June 17, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants