-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade python to 3.11 🐍 #22932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
reviewed
Jun 13, 2024
frankh
reviewed
Jun 13, 2024
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
looks like one other spot to bump the Python version IGNORE ME - fooled by a symlink |
wrt the hobby deploy - I'll fix that after this lands. Will probably require some attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'nuff said.
Steps to get this working are as such:
List of Changes
BooleanFields
withnull=True
. DRF changed the behavior for this, creating a null default if you don't pass it in from the frontend. We had been relying on the serializers to turn the nulls into Falses. This doesn't change behavior for existing models with Null (i think there is only one organization withis_hipaa
set to null instead of False). Fix BooleanField's allow_null behavior encode/django-rest-framework#8614class Foo(str, Enum)
)str
orint
Mixin Breaking Change in Python 3.11 python/cpython#100458ast.py
whereitem_type: ConstantType = UnknownType()
becameitem_type: ConstantType field(default_factory=UnknownType)
ci-backend.yml
checks out master and tries to migrate to it to test migrations, but this fails because of the version switch. Commented this out. Comment this back in after mergesudo
isn't okay in Dockerfile:35. Added ignore to the top of the file, as this docker is for dev and doesn't matter. https://github.com/PostHog/posthog/actions/runs/9517514426/job/26236279608?pr=22932