feat(monorepo): Merge rust services into Posthog as a subtree #22845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update and fix dockerfile * Update dependencies
The other version has glibc errors. I should investigate, but don't have time rn.
* Initial workspace setup I'd like to tidy a few things (dependencies etc), but get this setup asap to avoid awkward rebases going forwards. * Format and delete
* Add metrics middleware * Organize a bit better * Track a couple more things * Do not install metrics in tests * Add some lifetimes and fixes * Run formatter * Simplify routes * Fixes and feedback * Patch builds
It's taking SO long to build on my laptop I suspect something is up with docker. I'm 99% sure this should fix the image build though, as the binary has moved.
I rolled out the new image, saw the old took ages to kill, and realised we hadn't setup a SIGTERM handler. Add it!
* fill the data field in analytics events * fix todos
* Add Redis lib * `cargo update` * fmt * Add base implementation of billing limiter Supports 1. A fixed set of limits, with no redis update 2. A fixed set, subsequently updated from redis 3. No fixed set, updates from redis I still need to figure out how to nicely mock the redis connection that stll leaves enough not mocked to be worth testing. I really don't want integration tests on it :( Also still needs connecting to the API. Reading through the python for this is like 😵💫 * Rework I've reworked it a bunch. Honestly the background loop worked but it became really horrible and the locking behaviour a little sketchy. While this will slow down some requests a bit, unless it becomes measurably slow let's keep it that way rather than introducing a bit of a horrible pattern. * hook it all up * Add redis read timeout * Add non-cluster client * Respond to feedback
Turns out we never reset updated.
* Add tracing setup * fix --------- Co-authored-by: Xavier Vello <[email protected]>
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
|
[the snapshot tests and e2e are running on this PR because I touched those files for a test, it doesn't run by default, so shouldn't bork any |
benjackwhite
approved these changes
Jun 11, 2024
xvello
approved these changes
Jun 11, 2024
neilkakkar
force-pushed
the
merge-repos-try2
branch
from
ed5b98f to
ee6cd6d
Compare
neilkakkar
force-pushed
the
merge-repos-try2
branch
2 times, most recently
from
a30c668 to
65d1f80
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
force-pushed
the
merge-repos-try2
branch
from
4fc63ff to
6a7173b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adjusts CI so things work for the rust services, while not borking original CI.
Currently, I'm not adding any deep integrations between the two folders, this is just step 1 of making the workflow work.
For developing in posthog, nothing changes.
For developing rust services, you need to: cd rust/ and then nothing changes, still preserving all docker compose files generated here.
Preserves git history correctly.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?