feat(surveys): add configurable delay to popup surveys #22780

dmarticus · 2024-06-06T23:46:21Z

Problem

Many folks have been asking for us to add the ability to add a configurable delay to when our popup surveys appear on customer websites. Now, with this PR, they can do this!

Closes: #18102

Ships with the associated posthog-js changes: PostHog/posthog-js#1228

Changes

The PostHog app UI didn't change very much, I just added this checkbox to the "Customization" section:

Demo

Survey popup with no delay set

Survey popup with 5s delay

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Automated Tests

Wrote automated tests verifying the new API calls to add the surveyPopupDelay field to the appearance payload

Manual Tests

Survey with no delay set appears immediately
Survey with a delay set to 0 appears immediately
Survey with a delay set to 5s appears after 5 seconds
Survey cannot be set with a delay less than 0
Saving the delay (or lack of delay) on the survey persists
Multiple surveys appear ascending order, where the survey with no delay appears first, followed by surveys with delays
Only one survey ever appears at a time.

github-actions · 2024-06-06T23:55:57Z

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.06 MB

_{compressed-size-action}

posthog-bot · 2024-06-06T23:58:05Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T00:08:35Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T00:18:42Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T00:29:40Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T00:40:03Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T00:50:39Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T01:03:00Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T01:13:39Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T01:24:52Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-07T01:38:25Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…into feat/delay-survey-popup

…eatures

…into feat/delay-survey-popup

posthog-bot · 2024-06-24T20:14:48Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-24T20:30:50Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-contributions-bot · 2024-06-24T20:30:52Z

This issue has 2033 words at 41 comments. Issues this long are hard to read or contribute to, and tend to take very long to reach a conclusion. Instead, why not:

Write some code and submit a pull request! Code wins arguments
Have a sync meeting to reach a conclusion
Create a Request for Comments and submit a PR with it to the meta repo or product internal repo

Is this issue intended to be sprawling? Consider adding label epic or sprint to indicate this.

posthog-bot · 2024-06-24T22:06:21Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-24T22:22:24Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* initial commit * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * fixing the ui a bit * write tests for the survey_popup_delay api * remove todos that were todone * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update frontend/src/scenes/surveys/SurveyCustomization.tsx Co-authored-by: Phani Raj <[email protected]> * Update frontend/src/types.ts Co-authored-by: Phani Raj <[email protected]> * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * code review feedback * add hour max to survey delay * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * not sure how this was reverted, but it's back now * was this it? * was this it? * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * use latest version of posthog-js to activate the survey popup delay features * forgot to commit the lockfile * Update query snapshots * Update UI snapshots for `chromium` (2) * Update query snapshots * Update UI snapshots for `chromium` (2) * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update query snapshots * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Phani Raj <[email protected]>

initial commit

bf16859

dmarticus marked this pull request as draft June 6, 2024 23:46

Update UI snapshots for chromium (2)

5b2c1d5

Update UI snapshots for chromium (2)

59d5f71

Update UI snapshots for chromium (1)

d19810a

Update UI snapshots for chromium (1)

1e3c800

Update UI snapshots for chromium (2)

c48c4f6

Update UI snapshots for chromium (2)

728eef7

Update UI snapshots for chromium (2)

456c864

Update UI snapshots for chromium (2)

d2a526d

Update UI snapshots for chromium (2)

1531f6f

Update UI snapshots for chromium (2)

9afbdc5

dmarticus added 2 commits June 6, 2024 19:12

fixing the ui a bit

64e68b8

Merge branch 'feat/delay-survey-popup' of github.com:PostHog/posthog …

46a4b47

…into feat/delay-survey-popup

dmarticus requested a review from a team June 7, 2024 04:12

dmarticus added 2 commits June 7, 2024 15:32

write tests for the survey_popup_delay api

d3ca624

remove todos that were todone

1557789

dmarticus mentioned this pull request Jun 7, 2024

feat(surveys): add configurable delay to popup surveys PostHog/posthog-js#1228

Merged

dmarticus marked this pull request as ready for review June 7, 2024 23:24

github-actions bot and others added 8 commits June 24, 2024 16:36

Update query snapshots

fdb4f6a

Update query snapshots

7aa6782

use latest version of posthog-js to activate the survey popup delay f…

033b6bd

…eatures

Merge branch 'feat/delay-survey-popup' of github.com:PostHog/posthog …

220a291

…into feat/delay-survey-popup

forgot to commit the lockfile

45f9546

Merge branch 'master' into feat/delay-survey-popup

0ba5e0f

Update query snapshots

de4fac0

Update UI snapshots for chromium (2)

a8c7f6a

github-actions bot added 2 commits June 24, 2024 20:22

Update query snapshots

2354c1f

Update UI snapshots for chromium (2)

fa28581

github-actions bot added 7 commits June 24, 2024 20:34

Update query snapshots

f537add

Update query snapshots

bf0db84

Update query snapshots

ca1d4a9

Update query snapshots

260e930

Update query snapshots

f162eef

Update query snapshots

2ee6ce7

Update UI snapshots for chromium (2)

7f9b27f

Update UI snapshots for chromium (2)

dfcb609

github-actions bot added 2 commits June 24, 2024 22:32

Update query snapshots

ec3673b

Update query snapshots

262f597

dmarticus enabled auto-merge (squash) June 24, 2024 22:47

Update query snapshots

4669828

dmarticus merged commit f49e0af into master Jun 24, 2024
84 checks passed

dmarticus deleted the feat/delay-survey-popup branch June 24, 2024 23:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(surveys): add configurable delay to popup surveys #22780

feat(surveys): add configurable delay to popup surveys #22780

dmarticus commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

posthog-bot commented Jun 6, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 7, 2024

posthog-bot commented Jun 24, 2024

posthog-bot commented Jun 24, 2024

posthog-contributions-bot bot commented Jun 24, 2024

posthog-bot commented Jun 24, 2024

posthog-bot commented Jun 24, 2024

feat(surveys): add configurable delay to popup surveys #22780

feat(surveys): add configurable delay to popup surveys #22780

Conversation

dmarticus commented Jun 6, 2024 • edited Loading

Problem

Changes

Demo

Does this work well for both Cloud and self-hosted?

How did you test this code?

Automated Tests

Manual Tests

github-actions bot commented Jun 6, 2024 • edited Loading

posthog-bot commented Jun 6, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 7, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 24, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 24, 2024

📸 UI snapshots have been updated

posthog-contributions-bot bot commented Jun 24, 2024

posthog-bot commented Jun 24, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 24, 2024

📸 UI snapshots have been updated

dmarticus commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading