-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(billing): subscribe to all products (client side) #22768
feat(billing): subscribe to all products (client side) #22768
Conversation
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated13 snapshot changes in total. 0 added, 13 modified, 0 deleted:
Triggered by this commit. |
…om:PostHog/posthog into zach/subscribe-to-all-products/plan-levels
📸 UI snapshots have been updated11 snapshot changes in total. 0 added, 11 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Test failures here are not related to this PR so going to push it out |
Co-authored-by: Raquel Smith <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
See: https://github.com/PostHog/billing/pull/676
This PR is adding the UI changes for subscribe to all products. More details on the overall project in the PR linked above. The surface area for billing includes billing page, page gates and onboarding billing steps - so those are the areas this code will change.
As you can see it uses a mixture of the
SUBSCRIBE_TO_ALL_PRODUCTS
ff + thesubscription_level
to determine what experience to show. How the logic worksSUBSCRIBE_TO_ALL_PRODUCTS
fffree
/paid
subscription_level
then use the new experiencesThe core changes:
Note: this does not yet include the changes to the onboarding plan comparison showing all products
There is an intentional focus on not changing the experience for existing users.
Further notes:
has_active_subscription
will probably be migrated to usesubscription_level
in the futureOther PRs before this one to help make the changes simpler: