Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hogql): fix trends actors include recordings #22288

Merged
merged 6 commits into from
May 15, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented May 14, 2024

Problem

It's not possible to run trends actors query without including recordings. I think this is also what causes exports to fail: https://posthog.sentry.io/issues/5331742766/ (QuerySizeExceeded)

Changes

Implements the includeRecordings option

How did you test this code?

Verified insights still include recordings, but exports do not

@PostHog PostHog deleted a comment from sentry-io bot May 14, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

@thmsobrmlr thmsobrmlr requested a review from a team May 15, 2024 11:04
@thmsobrmlr
Copy link
Contributor Author

YOLOing / enabling auto merge

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) May 15, 2024 11:04
@thmsobrmlr thmsobrmlr merged commit fc9aea5 into master May 15, 2024
83 checks passed
@thmsobrmlr thmsobrmlr deleted the fix-hogql-trends-actors-include-recordings branch May 15, 2024 12:53
Copy link

sentry-io bot commented May 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: dateutil.relativedelta.relativedelta() argument after ** must be a mapping, not NoneType posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant