Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make links clickable in table #22002

Merged
merged 5 commits into from
May 15, 2024

Conversation

Pety99
Copy link
Contributor

@Pety99 Pety99 commented May 1, 2024

Problem

Links in the table are not clickable. It would be more convenient if users could click on them. This was raised in an issue here.

Changes

Links are now clickable in table entries and open in a new tab.
Screenshot 2024-04-30 at 20 24 12

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

  • Run Storybook
  • Open Properties Table
  • You can see the 3rd field with an URL that opens in a new tab

@Twixes Twixes requested review from thmsobrmlr and Twixes May 1, 2024 11:35
@Pety99
Copy link
Contributor Author

Pety99 commented May 14, 2024

@Twixes @thmsobrmlr Could you please take a look at this?

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great addition @Pety99. PR reads and works well, so I'll merge this in right away.

@thmsobrmlr thmsobrmlr merged commit d271ad1 into PostHog:master May 15, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants