Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use requests.exception.JSONDecodeError in try/except for billing service errors #21907

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

xrdt
Copy link
Contributor

@xrdt xrdt commented Apr 26, 2024

Problem

The exception type is correct. I'm simply silencing mypy errors that it doesn't exist so CI will pass.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@xrdt xrdt enabled auto-merge (squash) April 26, 2024 21:38
@xrdt xrdt merged commit d785d8c into master Apr 26, 2024
98 checks passed
@xrdt xrdt deleted the by/another-iteration-on-json-decode-error branch April 26, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants