fix(dashboards): HogQL support for dashboard filters on insights with property group filters #21903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
changed the title
Twixes
changed the title
webjunkie
approved these changes
Apr 29, 2024
| ) | ||
| except Exception as e: | ||
| # If pydantic is unhappy about the shape of data, let's ignore property filters and carry on | ||
| capture_exception() |
There was a problem hiding this comment.
Curious: Do we have Sentry configured to capture exception-level log message as exceptions? If so, we don't need to capture separately, as below is sufficient.
There was a problem hiding this comment.
We don't, but there's a way: https://github.com/kiwicom/structlog-sentry
| logger.error( | ||
| "Failed to apply dashboard property filters", | ||
| exception=e, | ||
| exc_info=True, |
There was a problem hiding this comment.
Can also use logger.exception and then you don't need the exc_info=True
There was a problem hiding this comment.
Oh yeah, that's exactly what I was looking for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
HogQL
apply_dashboard_filtersonly worked if the insight's query uses filters in list form – but typically these days, property filter groups are used. This failed (Sentry).Changes
Fixed the bug.
How did you test this code?
Updated
test_insight_refreshing_queryto use a property filter group instead of just list.