Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags): Defend against invalid data on creation #21893

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

neilkakkar
Copy link
Collaborator

Problem

... and don't put db down on dataErrors

Fixes https://posthog.sentry.io/issues/5214119968/?project=1899813&referrer=slack and https://posthog.sentry.io/issues/5250370222/?query=DataError&referrer=issue-stream&statsPeriod=24h&stream_index=0

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@neilkakkar neilkakkar requested a review from jurajmajerik April 26, 2024 12:37
@neilkakkar neilkakkar merged commit 181c61b into master Apr 29, 2024
96 of 97 checks passed
@neilkakkar neilkakkar deleted the fix-flags-data branch April 29, 2024 10:18
Copy link

sentry-io bot commented May 2, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'list' object has no attribute 'get' /api/projects/{parent_lookup_team_id}/surveys/{... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants