fix: Explicitly call out readonly user fields #21889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
commented
Apr 26, 2024
| @@ -86,7 +86,6 @@ class Meta: | |||
| "pending_email", | |||
| "email_opt_in", | |||
| "is_email_verified", | |||
| "pending_email", | |||
There was a problem hiding this comment.
This was a duplicate
webjunkie
approved these changes
Apr 26, 2024
fuziontech
added a commit
that referenced
this pull request
Apr 26, 2024
* master: (28 commits) fix: refactor update animation to do less (#21901) fix(plugin-server): add time component to person.force_upgrade (#21899) fix(dashboards): Indicate 404/400/500 properly (#21853) fix: recording exports (#21900) feat: Update SLAs, remove GitHub buttons (#21818) chore: Removed feature flag for heatmaps (#21886) fix(data-warehouse): Added an error message for empty data source files (#21843) feat(surveys): allow to stop surveys once reached enough responses (#21528) fix: patch missing pause method in rrweb (#21898) fix(hogql): make funnels fast again (#21890) fix: Explicitly call out readonly user fields (#21889) chore(dev): Allow mypy to run in VS Code extension (#21891) feat: Small heatmap UI fixes (#21849) feat: Improve Heatmaps UI and notices (#21887) fix: Redirection to keep query params (#21881) fix: hot path is cooler now (#21888) feat(data-warehouse): Moved the table model creation to the data pipeline activity (#21817) fix: snapshot response timings (#21885) chore(deps): Update posthog-js to 1.130.0 (#21884) feat(debug): tabs + better view for non-hogql-query nodes (#21867) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have a lot of validation but we should explicitly set all the readonly fields as readonly to prevent slip ups
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?