Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): HogQL support for dashboard filters on insights with global filters #21868

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 25, 2024

Problem

apply_dashboard_filters doesn't work when there are both dashboard-level filters AND the insight has global filters. See this error in Sentry. This is currently blocking rollout of HogQL calculation on dashboards.

Changes

Fixed.

How did you test this code?

Updated test_insight_refreshing_query, making sure it fails on master.

@Twixes Twixes requested a review from a team April 25, 2024 22:20
@Twixes Twixes enabled auto-merge (squash) April 26, 2024 08:28
@Twixes Twixes merged commit ad906da into master Apr 26, 2024
96 of 97 checks passed
@Twixes Twixes deleted the fix-hogql-apply-dashboard-filters-group branch April 26, 2024 08:43
Copy link

sentry-io bot commented Apr 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValidationError: 26 validation errors for PropertyGroupFilterValue /api/projects/{parent_lookup_team_id}/dashboard... View Issue
  • ‼️ ValidationError: 26 validation errors for PropertyGroupFilterValue /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ ValidationError: 26 validation errors for PropertyGroupFilterValue /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ ValidationError: 26 validation errors for PropertyGroupFilterValue /api/projects/{parent_lookup_team_id}/dashboard... View Issue
  • ‼️ ValidationError: 26 validation errors for PropertyGroupFilterValue /api/projects/{parent_lookup_team_id}/dashboard... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants