Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-server): set 'force_upgrade' for 'person_mode' when applicable #21856

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

bretthoerner
Copy link
Contributor

…icable## Problem

We need to note if $process_person_profile=false is used when a Person exists in the DB.

Changes

Set the enum as applicable.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Tests

@bretthoerner bretthoerner changed the title chore: add CH migration to add new person_mode option chore(plugin-server): set 'force_upgrade' for 'person_mode' when applicable Apr 25, 2024
@bretthoerner bretthoerner requested a review from tiina303 April 25, 2024 16:28
Copy link
Contributor

@tiina303 tiina303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bretthoerner bretthoerner merged commit 9701ada into master Apr 25, 2024
98 checks passed
@bretthoerner bretthoerner deleted the brett/force-upgrade branch April 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants