fix(dashboards): Indicate 404/400/500 properly #21853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
commented
Apr 25, 2024
| @@ -142,7 +142,7 @@ export const dashboardLogic = kea<dashboardLogicType>([ | |||
| }), | |||
|
|
|||
| actions({ | |||
| loadDashboardItems: (payload: { refresh?: boolean; action: string }) => payload, | |||
There was a problem hiding this comment.
This was some really legacy naming, from back when this literally had to load every dashboard item individually
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
webjunkie
approved these changes
Apr 26, 2024
Twixes
force-pushed
the
dashboard-error-pages
branch
from
8415dec to
0553bd5
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
fuziontech
added a commit
that referenced
this pull request
Apr 26, 2024
* master: (28 commits) fix: refactor update animation to do less (#21901) fix(plugin-server): add time component to person.force_upgrade (#21899) fix(dashboards): Indicate 404/400/500 properly (#21853) fix: recording exports (#21900) feat: Update SLAs, remove GitHub buttons (#21818) chore: Removed feature flag for heatmaps (#21886) fix(data-warehouse): Added an error message for empty data source files (#21843) feat(surveys): allow to stop surveys once reached enough responses (#21528) fix: patch missing pause method in rrweb (#21898) fix(hogql): make funnels fast again (#21890) fix: Explicitly call out readonly user fields (#21889) chore(dev): Allow mypy to run in VS Code extension (#21891) feat: Small heatmap UI fixes (#21849) feat: Improve Heatmaps UI and notices (#21887) fix: Redirection to keep query params (#21881) fix: hot path is cooler now (#21888) feat(data-warehouse): Moved the table model creation to the data pipeline activity (#21817) fix: snapshot response timings (#21885) chore(deps): Update posthog-js to 1.130.0 (#21884) feat(debug): tabs + better view for non-hogql-query nodes (#21867) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following #21822, we've been showing nonexistent dashboards as loading errors instead of 404 (the inverse of the issue we had before). We just need UI snapshots, since there's some logic involved.
Changes
Fixed the logic and added stories.