fix: same numbers everywhere #21848
Merged
fix: same numbers everywhere #21848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Apr 25, 2024
Comment on lines
-166
to
-167
| "viewport_width_min": "viewport_width >= ceil({viewport_width_min} / 16)", | ||
| "viewport_width_max": "viewport_width <= ceil({viewport_width_max} / 16)", |
There was a problem hiding this comment.
on the query side this is the only change
Comment on lines
-309
to
-314
| "x": 10 / 16, | ||
| "y": y / 16, | ||
| "x": round(x / 16), | ||
| "y": round(y / 16), | ||
| "scale_factor": 16, | ||
| # this adjustment is done at ingestion | ||
| "viewport_width": math.ceil(viewport_width / 16), | ||
| "viewport_height": math.ceil(viewport_height / 16), |
There was a problem hiding this comment.
but the test input data doesn't have the same shape as the real ingestion will generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at some point we started with
ceiland moved toroundor maybe just never consistently used them
certainly right now ingestion does
round(value/16)and queries assume eithervalue/16orround(value/16)🙈
this moves all the python and clickhouse calculations to assume
round(value/16)so we've the same everywhere