fix: skip custom split

[daibhin]

Problem

Looking at the performance inspector we can see CPU spiking on the main thread and a ton of time being taken up in the customSplit method

This was introduced in rrweb-io/rrweb#1401 which lines up with reports we've been getting of playback freezing in the last couple of days (we upgraded to alpha-13 yesterday #21734)

Changes

• Skip the customSplit method added
• This will reintroduce the bugs fixed by fix: nested css selector splitting #21427 but that seems like the less bad option right now

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Should see customers recordings playing back correctly

[daibhin]

@pauldambra @marandaneto I was totally over-eager here. I saw all green and accidentally yolo merged. It feels like a relatively safe change given things are pretty broken right now and I'm fairly confident this will fix things.

[marandaneto]

@pauldambra @marandaneto I was totally over-eager here. I saw all green and accidentally yolo merged. It feels like a relatively safe change given things are pretty broken right now and I'm fairly confident this will fix things.

All good, you have 6 YOLOs left, kidding, hopefully this fix everything o/

[pauldambra]

would be interesting to grab some of the real-world input that was causing this and see if we can write tests that demonstrate the problem so we can drive a fix

(all the regexes in that chain of code scare me 🤣)

[daibhin]

Sadly #21816 didn't fix the issue so I've gone ahead and removed the entire suspect commit.

@pauldambra think you're right. I'm working on a move to https://github.com/csstree/csstree which has proper CSS ast support