fix: Wrap asgi application to ignore lifetime requests #21802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
approved these changes
Apr 24, 2024
|
yep and i also got it running locally with no issues. I might canary it anyway just in case |
frankh
force-pushed
the
frank/ignore-lifetime-requests
branch
from
20bc9a0 to
71284f3
Compare
ASGI servers send "lifetime" requests to django at startup and shutdown. The ASGI spec allows these to fail, in which case the server ignores them, however the way django fails them sends an exception to sentry which we don't want. Overwrite the handler to return a 501 error without throwing an exception
frankh
force-pushed
the
frank/ignore-lifetime-requests
branch
from
71284f3 to
12b49e3
Compare
frankh
added a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ASGI servers send "lifetime" requests to django at startup and shutdown.
The ASGI spec allows these to fail, in which case the server ignores them, however the way django fails them sends an exception to sentry which we don't want.
Overwrite the handler to return a 501 error without throwing an exception
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?