Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-warehouse): Enable schema specific syncs during the onboarding wizard #21797

Merged
merged 4 commits into from
Apr 25, 2024
Merged

chore(data-warehouse): Enable schema specific syncs during the onboarding wizard #21797

merged 4 commits into from
Apr 25, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • After switching to schema-first syncs over source-first, I hadn't updated the onboarding wizard to show individual statuses for each schema

Changes

  • Show individual statuses for each schema during the wizard
  • Default all tables to be enabled for syncing as opposed to disabled
image

Does this work well for both Cloud and self-hosted?

  • Yes

How did you test this code?

  • Browser

@Gilbert09 Gilbert09 requested a review from EDsCODE April 24, 2024 10:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited
Loading

Size Change: +8.87 kB (+1%)

Total Size: 1.04 MB

Filename Size Change
frontend/dist/toolbar.js 1.04 MB +8.87 kB (+1%)

compressed-size-action

@Gilbert09 Gilbert09 merged commit c7d506b into master Apr 25, 2024
104 checks passed
@Gilbert09 Gilbert09 deleted the tom/warehouse-wizard-schema branch April 25, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @EDsCODE