feat: Add migration in advance of session properties PR - Part 2/2 #21777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
Base automatically changed from
add-migration-for-session-property-values
to
master
April 24, 2024 09:37
robbie-c
force-pushed
the
add-migration-for-session-property-values-2
branch
from
b1a849f to
c55888e
Compare
neilkakkar
approved these changes
Apr 24, 2024
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous migration (here #21703) was part 1 of 2
Changes
Run a migration to validate the previously unvalidated constraint. More info here https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-NOTES but this only gets a
SHARE UPDATE EXCLUSIVElock, which means that this doesn't prevent inserts/updates.Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
ran the migration locally, plus tests pass :)