feat(insights): open error in debug #21746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +657 B (0%) Total Size: 1.04 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
webjunkie
approved these changes
Apr 25, 2024
Twixes
approved these changes
Apr 25, 2024
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Error messages are hard to debug.
Changes
Just one more thing to make debugging easier. I added it to a few errors, not all, and didn't change much else. Would love to merge it in and fill in missing pieces later.
I believe we can expose this to users. Hopefully they'll even include "debug links" in their support requests.
Out of scope
There are still some issues with errors. I remember recently looking for and finding error messages in HTTP requests and not in the interface. Some errors themselves could use design cleanup. All of this needs a deeper dive.
How did you test this code?
Was investigating support cases, and couldn't get the query behind the error easily.