test(e2e): Treat HogQL insights as fully rolled out #21722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
commented
Apr 22, 2024
| @@ -279,7 +279,7 @@ def property_to_expr( | |||
| )[0:1].values_list("property_type", flat=True) | |||
| property_type = property_types[0] if property_types else None | |||
|
|
|||
| if not property_type or property_type == PropertyType.Boolean: | |||
There was a problem hiding this comment.
Had to change this assumption for retention.cy.ts to pass, as the legacy demo data generator used by E2E tests doesn't add a property definition for is_demo, hence the type is null – and we don't make this type assumption in the spot where we wrap the JSONExtractRaw output in bool parsing, so a type mismatch was guaranteed! @mariusandra
mariusandra
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Had some pain deploying #21595, because our E2E tests only test the legacy insights backend, whereas users experience the HogQL one.
Changes
It's time to use HogQL-based insights in Cypress.