Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(insights): HogQL calculation of saved legacy insights v2 #21718

Merged
merged 1 commit into from
Apr 22, 2024
Merged

revert(insights): HogQL calculation of saved legacy insights v2 #21718

merged 1 commit into from
Apr 22, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 22, 2024

Reverts #21595

@Twixes Twixes changed the title Revert "fix(insights): HogQL calculation of saved legacy insights v2" revert(insights): HogQL calculation of saved legacy insights v2 Apr 22, 2024
@Twixes Twixes merged commit 2f019a3 into master Apr 22, 2024
18 of 22 checks passed
@Twixes Twixes deleted the revert-21595-hogql-calculation-bis branch April 22, 2024 09:53
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.01 MB

compressed-size-action

Twixes added a commit that referenced this pull request Apr 22, 2024
@Twixes
Revert "revert(insights): HogQL calculation of saved legacy insights …
febf123 
…v2 (#21718)"

This reverts commit 2f019a3.
@Twixes Twixes mentioned this pull request Apr 22, 2024
Merged
@sentry-io Sentry.io
Copy link

sentry-io bot commented Apr 22, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotImplementedError: FieldAliasType.resolve_database_field not implemented posthog.tasks.tasks.process_query_task View Issue
  • ‼️ NotImplementedError: FieldAliasType.resolve_database_field not implemented posthog.tasks.tasks.process_query_task View Issue
  • ‼️ CHQueryErrorUnknownIdentifier: DB::Exception: Missing columns: '--events__override.distinct_id' '--events__override.person_id'... posthog.tasks.tasks.process_query_task View Issue
  • ‼️ TypeError: Property.init() missing 1 required positional argument: 'key' posthog.tasks.tasks.process_query_task View Issue
  • ‼️ NotImplementedError: FieldAliasType.resolve_database_field not implemented posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

Twixes added a commit that referenced this pull request Apr 23, 2024
@Twixes
Revert "revert(insights): HogQL calculation of saved legacy insights …
c1a029b 
…v2 (#21718)"

This reverts commit 2f019a3.
Twixes added a commit that referenced this pull request Apr 23, 2024
@Twixes
fix(insights): HogQL calculation of saved legacy insights v3 (#21720)
3ffa9ac 
* Revert "revert(insights): HogQL calculation of saved legacy insights v2 (#21718)"

This reverts commit 2f019a3.

* Fix `CACHE_ONLY` in place of `CALCULATION_ONLY_IF_STALE`

* Make `ExecutionMode` naming unmistakable

* Reset UI snapshots

* Account for #21707's `apply_dashboard_filters` change

* Make `QueryRunner` generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Twixes