chore: use a single timestamp format #21653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.01 MB ℹ️ View Unchanged
|
pauldambra
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
I can see basically nobody clicks the button... https://us.posthog.com/project/2/insights/0cg37THq so I don't think we're taking away something folk will care about
I wonder how discoverable the new behaviour is... should we have a tooltip?
|
@pauldambra I'm generally against adding tooltips unless necessary because we already have quite a few of them in the UI. Based on #21692 I'm hoping it might already be more visible / intuitive to people. Will monitor and add one to the button if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Towards #21302
We currently have two separate concepts of timestamp / timezone format on a single recording. Given there is now a visible timestamp toggle on the player I think we should only use one. This might be pushing the boat out because we're changing peoples behaviour but helps towards simplifying the inspector which is the most complicated part of the UI remaining.
Changes
Nicely connected to #21622 because we can now remove that entire row of buttons from the UI