fix(cohorts): Restrict query by time range #21621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enabling automerge so cohorts don't start struggling, but will accept all post-humous reviews |
neilkakkar
commented
Apr 17, 2024
| @@ -508,6 +508,9 @@ def assertQueryMatchesSnapshot(self, query, params=None, replace_all_numbers=Fal | |||
| query, | |||
| ) | |||
|
|
|||
| # replace explicit timestamps in cohort queries | |||
| query = re.sub(r"timestamp > '20\d\d-\d\d-\d\d \d\d:\d\d:\d\d'", r"timestamp > 'explicit_timestamp'", query) | |||
There was a problem hiding this comment.
I want this to fail in the year 2100 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I overlooked the part where we have a time range filter on cohorts, making exposure cohort queries (and any with explicit datetime) run farrr longer than they should 😬
Fixes that!
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?