feat: Send email notifications on failure #21609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/batch-exports-email-notification-on-failure
branch
from
c0140cb to
abb196a
Compare
bretthoerner
approved these changes
Apr 17, 2024
tomasfarias
force-pushed
the
feat/batch-exports-email-notification-on-failure
branch
from
cce390e to
a707e4f
Compare
tomasfarias
force-pushed
the
feat/batch-exports-email-notification-on-failure
branch
from
a707e4f to
69b9b14
Compare
* feat: Pause batch export on reaching failure threshold * fix: Pause only on non-retryable failures * refactor: Raise an exception on invalid check_window / failure_threshold
tomasfarias
deleted the
feat/batch-exports-email-notification-on-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users are not being properly notified when something goes wrong with their batch exports. This is particularly relevant for
NonRetryableErrorswhich require user input to fix (e.g. wrong credentials).Changes
Send an email notification when a batch export fails. This is done on a best effort basis, as I don't want to continuously fail if something goes wrong with the email sending.
NOTE: These are capped at one email per day per batch export to avoid spam. We achieve this by including the date component in the campaign key.
Here's how the email looks while testing locally:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
If self-hosted has an email server configured, should work too.
How did you test this code?
Added unit tests.