chore: move actions into single ellipsis menu #21606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
reviewed
Apr 17, 2024
| @@ -250,3 +255,68 @@ export function PlayerMeta(): JSX.Element { | |||
| </DraggableToNotebook> | |||
| ) | |||
| } | |||
|
|
|||
| const MenuActions = (): JSX.Element => { | |||
There was a problem hiding this comment.
that positioning makes it feel associated with the person instead of the recording...
it could go to the right of pin? which opens the road to that menu of actions becoming flexible and pushing more into the kebab menu on smaller screens...
|
Size Change: 0 B Total Size: 1000 kB ℹ️ View Unchanged
|
pauldambra
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Simplify the Replay UI / UX
Towards #21302 (comment)
Changes