Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup More button component #21588

Merged
merged 3 commits into from
Apr 18, 2024
Merged

chore: cleanup More button component #21588

merged 3 commits into from
Apr 18, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 16, 2024 •
edited
Loading

Problem

We have deprecated LemonButtonWithDropdown

Changes

  • Started into refactoring a component that used it (More)
  • Realised there were a few edge cases and it was looking like a rabbit hole
  • Backed out and am just going to ship the improvements I've made (for now...)

@daibhin daibhin requested a review from a team April 17, 2024 11:32
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 999 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 999 kB

compressed-size-action

@daibhin daibhin merged commit 2539c08 into master Apr 18, 2024
103 checks passed
@daibhin daibhin deleted the dn-chore/cleanup-component branch April 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daibhin