Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persons): single person query via postgres #21587

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Apr 16, 2024

Problem

Most users are currently on this mode:

  • persons list: via postgres
  • single person page: via postgres

We have the flag, persons-hogql-query, but it's disabled for most people. It enables the mode:

  • persons list: most via hogql, person column later via postgres
  • single person page: via hogql, joined with distinct ids (no postgres)

The problem is that while the persons list query loads really well, the "single person page" takes forever to load (~20sec for some teams), as ClickHouse really isn't great for one off searches.

Changes

Makes the persons-hogql-query flag only enable the HogQL/ClickHouse persons list, leaving the single person's page as it is.

This allows us to release the HogQL powered persons list to everyone.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Locally, got the old behaviour back.

@mariusandra mariusandra marked this pull request as ready for review April 16, 2024 16:07
@mariusandra mariusandra requested a review from a team April 16, 2024 16:08
Copy link
Contributor

Size Change: 0 B

Total Size: 999 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 999 kB

compressed-size-action

@mariusandra
Copy link
Collaborator Author

Going to move fast and merge it in as it's just removing something that's not released.

@mariusandra mariusandra merged commit 5f5d6a9 into master Apr 16, 2024
110 checks passed
@mariusandra mariusandra deleted the persons-api branch April 16, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant