Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ingestion experiment #21583

Merged
merged 3 commits into from
Apr 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: remove recording ingestion experiment
daibhin committed Apr 16, 2024

Verified

This commit was signed with the committer’s verified signature.
Sjors Sjors Provoost
commit 3570a5b3767541cb582727e023df8d0f270275b0
1 change: 0 additions & 1 deletion frontend/src/lib/constants.tsx
Original file line number Diff line number Diff line change
@@ -200,7 +200,6 @@ export const FEATURE_FLAGS = {
SAVED_NOT_PINNED: 'saved-not-pinned', // owner: #team-replay
BILLING_UPGRADE_LANGUAGE: 'billing-upgrade-language', // owner: @biancayang
NEW_EXPERIMENTS_UI: 'new-experiments-ui', // owner: @jurajmajerik #team-feature-success
SESSION_REPLAY_V3_INGESTION_PLAYBACK: 'session-replay-v3-ingestion-playback', // owner: @benjackwhite
SESSION_REPLAY_FILTER_ORDERING: 'session-replay-filter-ordering', // owner: #team-replay
SESSION_REPLAY_LINKED_VARIANTS: 'session-replay-linked-variants', // owner: #team-replay
REPLAY_ERROR_CLUSTERING: 'session-replay-error-clustering', // owner: #team-replay
Original file line number Diff line number Diff line change
@@ -337,11 +337,7 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([
null as SessionRecordingSnapshotSource[] | null,
{
loadSnapshotSources: async () => {
const params = {
version: values.featureFlags[FEATURE_FLAGS.SESSION_REPLAY_V3_INGESTION_PLAYBACK] ? '3' : '2',
}

const response = await api.recordings.listSnapshots(props.sessionRecordingId, params)
const response = await api.recordings.listSnapshots(props.sessionRecordingId, { version: 2 })
return response.sources ?? []
},
},
@@ -353,7 +349,7 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([
const params = {
source: source.source,
blob_key: source.blob_key,
version: values.featureFlags[FEATURE_FLAGS.SESSION_REPLAY_V3_INGESTION_PLAYBACK] ? '3' : '2',
version: '2',
}

const snapshotLoadingStartTime = performance.now()
1 change: 0 additions & 1 deletion posthog/management/commands/sync_feature_flags.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,6 @@
"cloud-announcement",
"session-reset-on-load",
"posthog-3000-nav",
"session-replay-v3-ingestion-playback",
]