-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Remove unused Python requirements #21580
Conversation
Reminds me of recent post: |
65a2af1
to
786b3ad
Compare
Oh, that's exactly the kind of thing I was thinking would be useful @webjunkie! Thanks, used it and found a few more seemingly-unused deps (though |
This reverts commit 7eaf899.
742079e
to
cd5709c
Compare
( |
I've barely touched Python here, so I'm not sure how confident you should be in my review. 😅 But the two deps I have touched (
So the 26 failed checks are just unrelated? I didn't dig in yet, tbh, they just look scary. :) |
Should fix CI failures caused by `curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)` (e.g. https://github.com/PostHog/posthog/actions/runs/8741861825/job/23988870688?pr=21580).
Yeah, that was some bout of Cypress flakiness @bretthoerner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts now 😢 but LGTM
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
Problem
Saw #21503 was opened to update
idna
, but that dependency actually seems to be unused.Changes
I think all of the below production Python dependencies are unused:
defusedxml
,idna
,amqp
,gevent
,geoip2
,importlib-metadata
,kafka-helper
,openapi-spec-validator
,parso
,pexpect
,pickleshare
,python3-saml
,requests-oauthlib
,urllib3