Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Remove unused Python requirements #21580

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 16, 2024

Problem

Saw #21503 was opened to update idna, but that dependency actually seems to be unused.

Changes

I think all of the below production Python dependencies are unused:
defusedxml, idna, amqp, gevent, geoip2, importlib-metadata, kafka-helper, openapi-spec-validator, parso, pexpect, pickleshare, python3-saml, requests-oauthlib, urllib3

@webjunkie
Copy link
Contributor

webjunkie commented Apr 16, 2024

Reminds me of recent post:

https://news.ycombinator.com/item?id=39724132

@Twixes Twixes force-pushed the rm-unused-py-deps branch from 65a2af1 to 786b3ad Compare April 16, 2024 16:40
@Twixes
Copy link
Member Author

Twixes commented Apr 16, 2024

Oh, that's exactly the kind of thing I was thinking would be useful @webjunkie! Thanks, used it and found a few more seemingly-unused deps (though deptry seems to ignore deps that are used as Django middleware and such)

@Twixes
Copy link
Member Author

Twixes commented Apr 18, 2024

(test_reload_external_data_source is currently failing on master, otherwise this is green)

@bretthoerner
Copy link
Contributor

bretthoerner commented Apr 18, 2024

I've barely touched Python here, so I'm not sure how confident you should be in my review. 😅 But the two deps I have touched (pyarrow and temporalio) are still there.

(test_reload_external_data_source is currently failing on master, otherwise this is green)

So the 26 failed checks are just unrelated? I didn't dig in yet, tbh, they just look scary. :)

@PostHog PostHog deleted a comment from github-actions bot Apr 18, 2024
@PostHog PostHog deleted a comment from github-actions bot Apr 19, 2024
@Twixes
Copy link
Member Author

Twixes commented Apr 19, 2024

Yeah, that was some bout of Cypress flakiness @bretthoerner

Copy link
Contributor

@bretthoerner bretthoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts now 😢 but LGTM

Copy link
Contributor

github-actions bot commented Apr 19, 2024

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.01 MB

compressed-size-action

@Twixes Twixes merged commit 233d3a9 into master Apr 22, 2024
100 checks passed
@Twixes Twixes deleted the rm-unused-py-deps branch April 22, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants