Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instrument alt click #21567

Merged
merged 2 commits into from
Apr 16, 2024
Merged

chore: instrument alt click #21567

merged 2 commits into from
Apr 16, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 16, 2024

Problem

Addresses #21544 (comment)

Changes

@pauldambra made the good point to see how much the feature is being used before removing it

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

N/A

@daibhin daibhin requested a review from pauldambra April 16, 2024 10:47
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Size Change: 0 B

Total Size: 999 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 999 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(assuming you've checked we can't pick it out with some clever autocapture filtering)

🚢

@daibhin
Copy link
Contributor Author

daibhin commented Apr 16, 2024

@pauldambra I created an action but couldn't see any attributed events so I assumed it wasn't working: https://us.posthog.com/project/2/data-management/actions/77198. I think clicks to the full row are being captured instead. Any idea if my selector should work?

@pauldambra
Copy link
Member

oof .SessionRecordingPreview > .grow > div:nth-child(2) > div > div:nth-child(1) > div yeah, that's yucky... we need to get way better at having data attributes on things 😅

@daibhin daibhin merged commit 76df829 into master Apr 16, 2024
103 checks passed
@daibhin daibhin deleted the dn-chore/instrument-alt-click-add branch April 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants