Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experiments): no results Trends diagnostics #21558

Merged
merged 2 commits into from
Apr 16, 2024
Merged

feat(experiments): no results Trends diagnostics #21558

merged 2 commits into from
Apr 16, 2024

Conversation

jurajmajerik
Copy link
Contributor

Changes

  • Implemented no results diagnostics for Trends
  • Tweaked the UI so it looks less like an interactive/clickable checklist and more like an automated one
image

How did you test this code?

unit tests, 👀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 999 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 999 kB

compressed-size-action

neilkakkar
neilkakkar approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love the UI tweak 🚀

@jurajmajerik jurajmajerik enabled auto-merge (squash) April 16, 2024 12:24
@jurajmajerik jurajmajerik merged commit 4d7e9d6 into master Apr 16, 2024
103 of 104 checks passed
@jurajmajerik jurajmajerik deleted the experiment-trend-results-diagnostics branch April 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurajmajerik @neilkakkar