-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): Use distinct_id
-based person overrides for PERSON_ID_OVERRIDE_PROPERTIES_JOINED
mode
#21520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Size Change: +155 kB (+18%) Total Size: 999 kB
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
tkaemming
changed the title
feat(hogql): Bring back support for
feat(hogql): Use Apr 16, 2024
distinct_id
-based person overridesdistinct_id
-based person overrides for PERSON_ID_OVERRIDE_PROPERTIES_JOINED
mode
timgl
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21504 did not implement reading from the new
person_distinct_id_overrides
table as the source for overrides, but that is the table we eventually want to use for HogQL queries as it has all of the data necessary to be transparently substitutable with the equivalent queries that do joins on the fullperson_distinct_id2
table.Changes
This updates the
PERSON_ID_OVERRIDE_PROPERTIES_JOINED
mode to use the newperson_distinct_id_overrides
table. This change should be safe to make for this version, since nobody was previously opted into this mode. The data returned by this mode should be generally the same as the data returned when not opted into any particular mode, so it should be safe to move teams in and out of this mode without any noticeable impact beyond improved performance.This leaves
PERSON_ID_OVERRIDE_PROPERTIES_ON_EVENTS
using the old table, and we can determine the upgrade path for those teams independently.This will result in support for legacy and HogQL queries for the modes introduced in #21504 as shown:
DISABLED
PERSON_ID_NO_OVERRIDE_PROPERTIES_ON_EVENTS
PERSON_ID_OVERRIDE_PROPERTIES_ON_EVENTS
person_overrides
(v2)PERSON_ID_OVERRIDE_PROPERTIES_JOINED
person_distinct_id_overrides
(v3)Does this work well for both Cloud and self-hosted?
Yes, this nobody should be using the override query modes.
How did you test this code?
Updated tests, also manually verified some queries via
/debug
.