-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-warehouse): external data job rewrite #21494
Conversation
…ync temporal calls
finally: | ||
heartbeat_task.cancel() | ||
await asyncio.wait([heartbeat_task]) | ||
for schema in schemas: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Haven't ever tried this in practice but seems reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added deletion logic, updated mypy baseline, fixed the resyncing logic, some frontend tweaks
Size Change: 0 B Total Size: 1000 kB ℹ️ View Unchanged
|
The failing migration check is on "null constraint for a small table" should be fine to merge. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
source
perspective, meaning:Changes
schema_id
in the input object, then:source
scheduleschema_id
exists in the input object, then continue as normalstatus
column toexternal_data_schema
- this is the new source of truth for the status of the syncstatus
column ofexternal_data_source
status
of a source is determined by the combination of all statuses of the sources schema childrenschema
is failing, them the source label will show asfailed
schema_id
to theexternal_data_jobs
table to hold which schema the job relates tocreate
source
API to trigger the correct jobsWhats not done:
Does this work well for both Cloud and self-hosted?
How did you test this code?
schedule
activity