feat: Support client side ingestion warnings #21388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
commented
Apr 8, 2024
| { alwaysSend: true } | ||
| ) | ||
|
|
||
| return this.registerLastStep('clientIngestionWarning', [event], [warningAck]) |
There was a problem hiding this comment.
Not super familiar with this code - I mostly copied it from the above example. Is the [event] part correct?
8 tasks
tiina303
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Ideally this wouldn't be in analytics ingestion lane, but we don't have a third ingestion lane ready yet, so ship it & only apply safety measures in posthog-js side PostHog/posthog-js#1051 (comment) for now & we can move / handle it differently later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to PostHog/posthog-js#1051
We want to send client ingestion warnings but we don't want them to be billable events.
Changes
$$client_ingestion_warningevent that will trigger an ingestion warning but drop the event@PostHog/team-pipeline open to renaming / any changes really - just went for PRs over issues 👍
Does this work well for both Cloud and self-hosted?
How did you test this code?
Tests