fix(experiments): compare the winning variant with the second best variant #21254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
|
Hmm, did we release the new UI already? makes sense to revert in that case. For the real fix, I think we can re-use this: If top sorted conversion rate is control, compare it with 2nd best, otherwise compare winning variant with control. |
|
hmm, makes sense! will do 👍 We haven't released it yet; want to do a demo tomorrow and then release it to the team + a few customers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recently I pushed a change to always compare the winning variant with
control. The problem is this doesn't work whencontrolis winning. Reverting it.It would be nice to figure out a way to compare the winning variant with the current baseline.
How did you test this code?
👀