Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start collecting enhanced_persons metrics in usage reports #21246

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

To add enhanced_persons addon to billing, need to start collecting some value in usage_reports with the usage_key.

Changes

Adds the metric to the usage_reports. The metric is currently the same exact as base events, because they are the exact same for now. When we have the column to query against to determine which events are actually enhanced_persons we will update the query here.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes.

How did you test this code?

Updated test. Query snapshots should update automatically.

Copy link

sentry-io bot commented Mar 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/tasks/usage_report.py

Function Unhandled Issue
get_teams_with_billable_event_count_in_period CHQueryErrorTooManySimultaneousQueries: Code: 202. posthog.tasks.tasks.update_quota_limiti...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@raquelmsmith raquelmsmith requested a review from a team April 1, 2024 13:25
@raquelmsmith raquelmsmith merged commit 25db327 into master Apr 2, 2024
76 checks passed
@raquelmsmith raquelmsmith deleted the feat/enhanced-persons-usage-reports-value branch April 2, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants