feat(experiments): explore results in an insight #21235
Conversation
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 845 kB ℹ️ View Unchanged
|
frontend/src/queries/schema.ts
Outdated
| @@ -624,6 +624,8 @@ export interface InsightsQueryBase extends Node { | |||
| aggregation_group_type_index?: integer | |||
| /** Sampling rate */ | |||
| samplingFactor?: number | null | |||
|
|
|||
| explicitDate?: boolean | |||
There was a problem hiding this comment.
Fly-by comment (off for easter, will have a deeper look next Tuesday) - I don't think we handle this setting in the new insights at all. Seems it gets passed in via the date range filter. I'll look into adding it and would appreciate any context :) After a first look I'd think this should belong into the dateRange object?
There was a problem hiding this comment.
Didn't see the DateRange component before, but agree should go there!
For context, we need this setting whenever we don't want to round date ranges to start and end of day. This is particularly important for experiments because we want to discard all testing data that came before the exact moment the experiment began.
There was a problem hiding this comment.
We'll need this setting as well to move both trends & funnel experiments backend off of filters and onto query 😅
There was a problem hiding this comment.
For more context, the appropriate setting in filters is: https://github.com/PostHog/posthog/blob/master/posthog/schema.py#L2549
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
There was a problem hiding this comment.
@jurajmajerik please take a look once.
I'll do the hiding baseline in a follow up (or maybe never :P ) because it needs to touch the insight internals quite a bit
| @@ -32,7 +29,7 @@ export function ExperimentView(): JSX.Element { | |||
| <PageHeaderCustom /> | |||
| <div className="space-y-8 experiment-view"> | |||
| {experimentLoading ? ( | |||
| <ExperimentLoader /> | |||
| <LoadingState /> | |||
There was a problem hiding this comment.
added a non-list based skeleton, looked nicer to me
| const { experimentId, editingExistingExperiment, experimentMissing } = useValues(experimentLogic) | ||
|
|
||
| if (experimentMissing) { | ||
| return <NotFound object="experiment" /> |
There was a problem hiding this comment.
handling not found states for new UI
| @@ -284,7 +283,7 @@ export function SecondaryMetricsTable({ | |||
|
|
|||
| <div className="w-1/2 flex flex-col justify-end"> | |||
| <div className="ml-auto"> | |||
| {metrics && metrics.length > 0 && metrics.length < 3 && isExperimentRunning && ( | |||
| {metrics && metrics.length > 0 && metrics.length < 3 && ( | |||
There was a problem hiding this comment.
On Draft mode you could only add one secondary metric 😅
There was a problem hiding this comment.
now extending this to stopped experiments as well
|
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Nice! Great that you've added the Explore button to the empty state too 👍 |
Changes
Adds the ability to explore experiment results in an insight.
To make sure we correctly query all participants we need to work with the exact start/end time of the experiment, as opposed to time rounded to start/end of day.
Unfortunately, the query doesn't manage to load when the hogql-insight-funnels flag is enabled - see below. @thmsobrmlr - can you please help us out?
UI follow-ups:
How did you test this code?
👀